fix(NcRichContenteditable): Fix tribute emoji complete interfering unexpectedly aka. 🇨🇨 #3924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
added
bug
nickvergessen
requested review from
mejo-,
skjnldsv,
ShGKme,
marcoambrosini and
Antreesy
…expectedly aka. Cocos Island Meme Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
bugfix/3825/fix-emoji-autocomplete
branch
from
28f4500
to
2b371da
Compare
Signed-off-by: Joas Schilling <[email protected]>
mejo-
requested changes
Mar 24, 2023
There was a problem hiding this comment.
To be honest, I think that #3923 is the cleaner approach. It doesn't affect the EmojiPicker component either, the search function is only used by emoji autocompletion implementions in NcRichContenteditable and Text/Collectives. That's also why I think that it's the proper place to fix this.
mejo-
approved these changes
Mar 24, 2023
|
After some discussion in the chat we agreed to go with both approaches in parallel:
|
This was referenced Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🪦 Cocos-Island Meme
Opposed to #3923 I fixed it in
NcRichContenteditableso that other components like the emoji picker itself are not interfered and still operate normally.